Skip to content

Remove assert I accidentally left in (I meant to remove it when I re-added the defensive check above). #565

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Mar 15, 2018
Merged

Remove assert I accidentally left in (I meant to remove it when I re-added the defensive check above). #565

merged 1 commit into from
Mar 15, 2018

Conversation

mikelehen
Copy link
Contributor

Sorry, I meant to remove this assert when responding to your CR feedback yesterday, but apparently failed.

@mikelehen mikelehen requested a review from wilhuff March 15, 2018 18:09
@mikelehen mikelehen removed the request for review from schmidt-sebastian March 15, 2018 18:09
wilhuff
wilhuff approved these changes Mar 15, 2018
View reviewed changes
Copy link
Contributor

@wilhuff wilhuff left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@wilhuff wilhuff assigned mikelehen and unassigned wilhuff Mar 15, 2018
@mikelehen mikelehen merged commit df183a5 into master Mar 15, 2018
@mikelehen mikelehen deleted the mikelehen/remove-accidental-assert-from-last-PR branch March 15, 2018 19:04
@firebase firebase locked and limited conversation to collaborators Oct 22, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers
1 more reviewer

@wilhuff wilhuff wilhuff approved these changes

Reviewers whose approvals may not affect merge requirements
Assignees

@mikelehen mikelehen

Labels
api: firestore
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@mikelehen @wilhuff @google-oss-bot